Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add usb msc support for nrf52840 #5011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikesmitty wants to merge 3 commits into tinygo-org:dev
base: dev
Choose a base branch
Loading
from mikesmitty:ms/nrf-msc-support

Conversation

@mikesmitty
Copy link
Contributor

@mikesmitty mikesmitty commented Aug 23, 2025

I don't have an nrf52840 on hand to test yet (should have one tomorrow), but I figured I'd push this up in case @aykevl or anyone else wanted to give it a whirl
#4844 (comment)

Copy link
Member

aykevl commented Aug 24, 2025
edited
Loading

I tried this, but sadly it doesn't work.
I haven't investigated why it doesn't work though.

mikesmitty reacted with thumbs up emoji

Copy link
Contributor Author

No worries, my nrf52840 just showed up so I'll investigate

Copy link
Member

@mikesmitty any update on this? I would really like to have it for something... 😸

Copy link
Contributor Author

Oh yeah, this fell off my radar. I've got a debugger just about set up with an nrf52840 now so I can dig into this again

Copy link
Contributor Author

Ok, at least in my testing it looks like it's just a problem with m.buf being too small. My test device has a write block size of 4 bytes, which I didn't think would ever happen. The m.buf buffer is set, perhaps a bit naively, to use the write block size as a capacity, but it needs to be 64 bytes at a minimum to be able to store a full usb packet and it's panicking. #5017 also modifies these buffer sizes but in a more expansive way so this will likely end up just being a temporary patch. I just saw Ayke commented again on that one so I'll swap back to that one next

@mikesmitty mikesmitty changed the base branch from release to dev September 17, 2025 13:07
Copy link
Member

Pinging Dr. @mikesmitty 😸

mikesmitty reacted with laugh emoji

Copy link
Contributor Author

mikesmitty commented Oct 23, 2025
edited
Loading

Sorry, been getting distracted a lot recently haha. I'll start working on this again this weekend

deadprogram and b0ch3nski reacted with heart emoji

Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /