Files that changed from the base of the PR and between 38913e5 and 5c1ffa7.

• packages/ui/src/components/TextInput/TextInput.tsx (3 hunks)
• packages/ui/src/components/TextInput/theme.ts (1 hunks)

packages/ui/src/components/TextInput/theme.ts (1)

15-15: Removal of pointer-events-none enables click events on the right icon

The removal of the pointer-events-none class from the rightIcon.base property aligns with the PR objective of adding an onRightIconClick prop to the TextInput component. This change allows click events to be captured on the right icon, which is necessary for implementing features like toggling password visibility.

However, there are a few considerations:

1. Ensure that this change is accompanied by appropriate updates in the component's logic to handle the click events.
2. Consider adding a cursor style (e.g., cursor-pointer) to visually indicate that the icon is clickable.
3. Verify that this change doesn't introduce any unintended side effects for existing uses of the TextInput component.

To ensure this change is properly implemented and doesn't cause regressions, please run the following verification script:

Verification successful

---

Conditional application of pointer-events-none is correctly implemented

The pointer-events-none class is now conditionally applied based on the presence of the onRightIconClick prop. This ensures that click events on the right icon are only enabled when an onRightIconClick handler is provided, aligning with the PR's objective.

No unintended uses of pointer-events-none remain when onRightIconClick is defined.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the implementation of onRightIconClick in TextInput component
# Test 1: Check if the TextInput component has been updated to handle onRightIconClick
echo "Checking TextInput component for onRightIconClick implementation:"
ast-grep --lang typescript --pattern 'interface TextInputProps {
 $$$
 onRightIconClick?: $_
 $$$
}'
# Test 2: Look for examples or tests demonstrating the use of onRightIconClick
echo "Searching for examples or tests using onRightIconClick:"
rg --type typescript "onRightIconClick" -C 5
# Test 3: Ensure no unintended uses of pointer-events-none remain for the right icon
echo "Checking for any remaining pointer-events-none on right icons:"
rg --type typescript "rightIcon.*pointer-events-none"

Length of output: 673

---

Script:

#!/bin/bash
# Description: Re-verify the implementation of onRightIconClick in TextInput component with corrected file types
# Test 1: Check if the TextInput component has been updated to handle onRightIconClick
echo "Checking TextInput component for onRightIconClick implementation:"
ast-grep --lang typescript --pattern 'interface TextInputProps {
 $$$
 onRightIconClick?: $_
 $$$
}'
# Test 2: Look for examples or tests demonstrating the use of onRightIconClick
echo "Searching for examples or tests using onRightIconClick:"
rg "onRightIconClick" -C 5 --type ts
# Test 3: Ensure no unintended uses of pointer-events-none remain for the right icon
echo "Checking for any remaining pointer-events-none on right icons:"
rg "rightIcon.*pointer-events-none" --type ts

Length of output: 3566

packages/ui/src/components/TextInput/TextInput.tsx (3)

49-49: LGTM: New prop onRightIconClick added correctly

The addition of the onRightIconClick prop to the TextInputProps interface is implemented correctly. It's defined as an optional function returning void, which is appropriate for a click event handler. This change aligns well with the PR objectives of enabling password visibility toggle functionality.

---

64-64: LGTM: onRightIconClick prop correctly destructured

The onRightIconClick prop is correctly added to the destructured props in the component. This makes the new prop available for use within the component, which is necessary for implementing the desired functionality.

---

Line range hint 1-114: Overall assessment: Well-implemented feature with minor suggestion

The implementation of the onRightIconClick prop in the TextInput component is well done and aligns perfectly with the PR objectives. The changes are clean, follow existing patterns, and improve the component's functionality without introducing any major issues.

Key points:

1. The new prop is correctly added to the interface and component.
2. The implementation in JSX is sound, with good UX considerations (disabling pointer events when no handler is provided).
3. A small suggestion was made to add a null check for extra safety when calling onRightIconClick.

Great job on this feature implementation!

Files that changed from the base of the PR and between 5c1ffa7 and 1965831.

• packages/ui/src/components/TextInput/TextInput.tsx (3 hunks)

packages/ui/src/components/TextInput/TextInput.tsx (3)

49-49: LGTM: New prop onRightIconClick added correctly

The addition of the onRightIconClick prop to the TextInputProps interface is well-implemented. It's correctly defined as an optional prop with the appropriate event type, which aligns with the PR objectives and enhances the component's functionality.

---

64-64: LGTM: onRightIconClick correctly destructured

The onRightIconClick prop is correctly destructured from the component's props, making it available for use within the component. This change is consistent with the addition of the new prop and follows the existing code structure.

---

Line range hint 1-114: Overall assessment: Good implementation with minor improvement suggested

The changes in this file successfully implement the new onRightIconClick functionality for the TextInput component. The new prop is correctly added to the interface, destructured in the component, and integrated into the rendering logic. The implementation aligns well with the PR objectives and follows existing code patterns.

A minor improvement was suggested for the onClick implementation to ensure consistent behavior and avoid unnecessary function creation. With this small change, the implementation will be even more robust and efficient.

Great job on enhancing the TextInput component's functionality!

Files that changed from the base of the PR and between 1965831 and 061dc17.

• packages/ui/src/components/TextInput/TextInput.tsx (3 hunks)

packages/ui/src/components/TextInput/TextInput.tsx (3)

49-49: LGTM: New prop onRightIconClick correctly added

The new onRightIconClick prop is correctly defined as an optional function with the appropriate event type. This addition aligns well with the PR objectives and provides good type safety for users of the component.

---

64-64: LGTM: onRightIconClick correctly destructured

The onRightIconClick prop is correctly added to the destructured props, making it available for use within the component. Its placement among other similar props is appropriate.

---

Line range hint 1-118: Summary: Successfully implemented onRightIconClick with minor improvement suggested

The changes in this file successfully implement the new onRightIconClick functionality for the TextInput component, aligning well with the PR objectives. The new prop is correctly defined, destructured, and integrated into the component's logic. The addition of data-testid and the conditional class for pointer events are good improvements for testability and UX.

A minor improvement was suggested for the onClick implementation to enhance type safety and ensure proper event handling. Overall, the changes are well-implemented and ready for merging after addressing the suggested improvement.