Commit 47a8e67

authored

Merge pull request #35 from lxcid/lxcid/spec-compliant

Make serialized error spec compliant

2 parents d57470d + c3d938a commit 47a8e67Copy full SHA for 47a8e67

File tree

+12

-8

lines changed

+12

-8

lines changed

Lines changed: 11 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,11 +16,13 @@ export interface ErrorConfig {`
`16`	`16`
`17`	`17`	`export interface ErrorInfo {`
`18`	`18`	`message: string;`
`19`		`- name: string;`
`20`		`- time_thrown: string;`
`21`		`- data?: object;`
`22`	`19`	`path?: string;`
`23`	`20`	`locations?: any;`
	`21`	`+ extensions?: {`
	`22`	`+ name: string;`
	`23`	`+ time_thrown: string;`
	`24`	`+ data?: object;`
	`25`	`+ };`
`24`	`26`	`}`
`25`	`27`
`26`	`28`	`export class ApolloError extends ExtendableError {`
`@@ -59,11 +61,13 @@ export class ApolloError extends ExtendableError {`
`59`	`61`
`60`	`62`	`let error: ErrorInfo = {`
`61`	`63`	`message,`
`62`		`- name,`
`63`		`- time_thrown,`
`64`		`- data,`
`65`	`64`	`path,`
`66`		`- locations`
	`65`	`+ locations,`
	`66`	`+ extensions: {`
	`67`	`+ name,`
	`68`	`+ time_thrown,`
	`69`	`+ data`
	`70`	`+ }`
`67`	`71`	`};`
`68`	`72`
`69`	`73`	`if (_showLocations) {`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ describe('createError', () => {`
`31`	`31`	`},`
`32`	`32`	`});`
`33`	`33`
`34`		`- const { message, name, time_thrown, data } = e.serialize();`
	`34`	`+ const { message, extensions: {name, time_thrown, data} } = e.serialize();`
`35`	`35`	`expect(message).to.equal('A foo 2.0 error has occurred');`
`36`	`36`	`expect(name).to.equal('FooError');`
`37`	`37`	`expect(time_thrown).to.equal(e.time_thrown);`

Comments

(0)