Commit c3d938a

committed

Make serialized error spec compliant

Summary: An update recently in `facebook/graphql/spec/Section 7 -- Response.md` specify that GraphQL services may provide an additional entry to errors with key `extensions`. Although non-specified entries are not violations, they are still discouraged. This update try to follow through with the spec recommendation.

1 parent b7e8814 commit c3d938aCopy full SHA for c3d938a

File tree

2 files changed

+12

-8

lines changed

src
- index.ts
test
- spec.js

2 files changed

+12

-8

lines changed

`‎src/index.ts‎`

Lines changed: 11 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,11 +16,13 @@ export interface ErrorConfig {`
`16`	`16`
`17`	`17`	`export interface ErrorInfo {`
`18`	`18`	`message: string;`
`19`		`- name: string;`
`20`		`- time_thrown: string;`
`21`		`- data?: object;`
`22`	`19`	`path?: string;`
`23`	`20`	`locations?: any;`
	`21`	`+ extensions?: {`
	`22`	`+ name: string;`
	`23`	`+ time_thrown: string;`
	`24`	`+ data?: object;`
	`25`	`+ };`
`24`	`26`	`}`
`25`	`27`
`26`	`28`	`export class ApolloError extends ExtendableError {`
`@@ -56,11 +58,13 @@ export class ApolloError extends ExtendableError {`
`56`	`58`
`57`	`59`	`let error: ErrorInfo = {`
`58`	`60`	`message,`
`59`		`- name,`
`60`		`- time_thrown,`
`61`		`- data,`
`62`	`61`	`path,`
`63`		`- locations`
	`62`	`+ locations,`
	`63`	`+ extensions: {`
	`64`	`+ name,`
	`65`	`+ time_thrown,`
	`66`	`+ data`
	`67`	`+ }`
`64`	`68`	`};`
`65`	`69`
`66`	`70`	`if (_showLocations) {`

`‎test/spec.js‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ describe('createError', () => {`
`31`	`31`	`},`
`32`	`32`	`});`
`33`	`33`
`34`		`- const { message, name, time_thrown, data } = e.serialize();`
	`34`	`+ const { message, extensions: {name, time_thrown, data} } = e.serialize();`
`35`	`35`	`expect(message).to.equal('A foo 2.0 error has occurred');`
`36`	`36`	`expect(name).to.equal('FooError');`
`37`	`37`	`expect(time_thrown).to.equal(e.time_thrown);`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit c3d938a

File tree

2 files changed

2 files changed

`‎src/index.ts‎`

`‎test/spec.js‎`

0 commit comments