Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

41 functional rendering #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfcook merged 3 commits into master from 41-functional-rendering
Aug 13, 2019
Merged

41 functional rendering #82

dfcook merged 3 commits into master from 41-functional-rendering
Aug 13, 2019

Conversation

@dfcook
Copy link
Collaborator

@dfcook dfcook commented Aug 13, 2019

Addresses #41

  1. Adds example of functional rendering using a render function.
  2. Adds support for functional SFC's without a component definition by checking the isVueInstance property of the wrapper before calling destroy.

@dfcook dfcook requested a review from afontcu August 13, 2019 08:54
Copy link

codecov bot commented Aug 13, 2019 •
edited
Loading

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #82 +/- ##
=====================================
 Coverage 100% 100% 
=====================================
 Files 1 1 
 Lines 62 64 +2 
 Branches 10 11 +1 
=====================================
+ Hits 62 64 +2
Impacted Files Coverage Δ
src/vue-testing-library.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f462051...4977568. Read the comment docs.

Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice catch! 💯

(added a couple of inline suggestions to remove what appears to be some debugging boilerplate).

@dfcook dfcook merged commit 08500e4 into master Aug 13, 2019
@dfcook dfcook deleted the 41-functional-rendering branch August 13, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afontcu afontcu afontcu approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /