Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: add missed optional prop for emmited function #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

@thunderer199
Copy link
Contributor

@thunderer199 thunderer199 commented Jul 16, 2022

Vue test utils allow to pass event name into emitted() to receive array of calls
emitted().foo can be written as emitted('foo')
You can see it here

Copy link

codecov bot commented Jul 16, 2022
edited
Loading

Codecov Report

Merging #276 (10b8fb5) into main (20ceb25) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@
## main #276 +/- ##
=========================================
 Coverage 100.00% 100.00% 
=========================================
 Files 3 3 
 Lines 78 78 
 Branches 28 27 -1 
=========================================
 Hits 78 78 
Impacted Files Coverage Δ
src/render.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ceb25...10b8fb5. Read the comment docs.

Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks!

@afontcu afontcu merged commit 6dd4847 into testing-library:main Jul 16, 2022
Copy link

🎉 This PR is included in version 6.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@thunderer199 thunderer199 deleted the fix/add-missed-emitted-prop branch September 25, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afontcu afontcu afontcu approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /