-
Notifications
You must be signed in to change notification settings - Fork 113
Rename index file to simplify test imports #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your recent PRs, sorry it's taken a while to get around to looking at them.
@dfcook oh no, thank you! Really happy to help. Feel free to ping me if you need some help or if you know any area that could use some love!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
By renaming the sole file of vue-testing-library, and making use of jest' moduleDirectories, example tests might look a bit simpler. If this PR is merged, tests would be "copy-pastable" into another project.
btw, I assumed that modifying the
mainkey inpackage.jsonwould make everything work as expected. If that's not the case and you are still interested in this PR, point me to the right direction and I'll change it.Thanks! 😃