feat: Remove Router/Vuex for Vue 3 #206

@@ Coverage Diff @@
## next #206 +/- ##
=========================================
 Coverage 100.00% 100.00% 
=========================================
 Files 3 3 
 Lines 84 77 -7 
 Branches 30 27 -3 
=========================================
- Hits 84 77 -7

Impacted Files	Coverage Δ
src/render.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa00f27...400d9f4. Read the comment docs.

@afontcu afontcu marked this pull request as ready for review

February 11, 2021 11:34

@afontcu afontcu mentioned this pull request

Feb 11, 2021

[RFC] Remove custom router/vuex management for Vue 3 #205

Closed

ITenthusiasm

ITenthusiasm reviewed

Feb 12, 2021

View reviewed changes

Copy link

Contributor

@ITenthusiasm ITenthusiasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I've contributed a little, I haven't seen the entire codebase. So some curious questions will pop up here and there. 😅

types/index.d.ts Outdated Show resolved Hide resolved

types/test.ts Show resolved Hide resolved

src/index.js Outdated Show resolved Hide resolved

src/__tests__/vuex.js Show resolved Hide resolved

src/__tests__/vue-router.js Show resolved Hide resolved

@afontcu

Copy link

Member Author

afontcu commented Feb 13, 2021

Although I've contributed a little, I haven't seen the entire codebase. So some curious questions will pop up here and there. 😅

Thank you for your thoughts!

@afontcu afontcu force-pushed the remove-router-vuex branch from 7afe821 to 544c49d Compare

February 13, 2021 18:50

codfish

codfish approved these changes

Feb 17, 2021

View reviewed changes

@afontcu afontcu added the BREAKING CHANGE label

Feb 17, 2021

@codfish

Copy link

codfish commented Feb 17, 2021

hey @afontcu! looking forward to this change! Out of curiosity, when do you see this being released? I'm migrating to VTL now, but wondering if I should continue on my path or wait a little bit for this change to be released. Also, should we expect this to result in v6?

@afontcu

Copy link

Member Author

afontcu commented Feb 17, 2021

hey @afontcu! looking forward to this change! Out of curiosity, when do you see this being released? I'm migrating to VTL now, but wondering if I should continue on my path or wait a little bit for this change to be released. Also, should we expect this to result in v6?

Hi! Yeah, I plan on releasing it next week. And yeah, I'll release it as a minor version of 6.x, the major range version for Vue 3 :)