Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: Reenable Vue Router for Vue 3 #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afontcu merged 3 commits into next from enable-vue-3-router
Dec 9, 2020
Merged

feat: Reenable Vue Router for Vue 3 #191

afontcu merged 3 commits into next from enable-vue-3-router
Dec 9, 2020

Conversation

@afontcu
Copy link
Member

@afontcu afontcu commented Dec 9, 2020

Vue Router is out of beta and looks like we already provide basic support.

// expect(queryByTestId('location-display')).toHaveTextContent('/about')
// })

// test('setting initial route', () => {
Copy link
Member Author

@afontcu afontcu Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this test is no longer doable

Copy link

codecov bot commented Dec 9, 2020 •
edited
Loading

Codecov Report

Merging #191 (5429560) into next (3ef7112) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph 

@@ Coverage Diff @@
## next #191 +/- ##
=========================================
 Coverage 100.00% 100.00% 
=========================================
 Files 1 1 
 Lines 86 92 +6 
 Branches 27 30 +3 
=========================================
+ Hits 86 92 +6
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ef7112...5429560. Read the comment docs.

@afontcu afontcu changed the title (削除) Vue 3: Reenable Vue Router example (削除ここまで) (追記) Vue 3: Reenable Vue Router (追記ここまで) Dec 9, 2020
@afontcu afontcu changed the title (削除) Vue 3: Reenable Vue Router (削除ここまで) (追記) feat: Reenable Vue Router for Vue 3 (追記ここまで) Dec 9, 2020
@afontcu afontcu merged commit 22df352 into next Dec 9, 2020
@afontcu afontcu deleted the enable-vue-3-router branch December 9, 2020 21:28
Copy link

github-actions bot commented Dec 9, 2020

🎉 This PR is included in version 6.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /