Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

chore(ci): Enable typecheck #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afontcu merged 3 commits into next from reenable-typecheck
Jul 30, 2021
Merged

chore(ci): Enable typecheck #189

afontcu merged 3 commits into next from reenable-typecheck
Jul 30, 2021

Conversation

@afontcu
Copy link
Member

@afontcu afontcu commented Dec 3, 2020 •
edited
Loading

(削除) Build won't pass until we find a fix for this: microsoft/dtslint#297 (comment) (削除ここまで)

update: as @nickmccurdy suggested, switching to tsd did the trick!

Copy link
Member

nickserv commented Jul 6, 2021

Alternatively you may be able to use tsd or ts-expect.

Copy link
Member Author

afontcu commented Jul 6, 2021

Alternatively you may be able to use tsd or ts-expect.

sure, I'll take a look! Thank you for the suggestion

@afontcu afontcu changed the title (削除) Enable typecheck (削除ここまで) (追記) chore(ci): Enable typecheck (追記ここまで) Jul 30, 2021
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #189 (89c9bd0) into next (6f1ffbc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph 

@@ Coverage Diff @@
## next #189 +/- ##
=========================================
 Coverage 100.00% 100.00% 
=========================================
 Files 3 3 
 Lines 77 77 
 Branches 27 27 
=========================================
 Hits 77 77

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f1ffbc...89c9bd0. Read the comment docs.

Copy link
Member Author

afontcu commented Jul 30, 2021

I'm merging this, if anyone comes up with a fix for dtslint or a better way to express type testing, I'll be more than happy to review the PR 😃

@afontcu afontcu merged commit 93317d9 into next Jul 30, 2021
@afontcu afontcu deleted the reenable-typecheck branch July 30, 2021 14:43
Copy link

github-actions bot commented Aug 1, 2021

🎉 This PR is included in version 6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /