-
Notifications
You must be signed in to change notification settings - Fork 113
Use @testing-library/jest-dom in README.md
#172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use @testing-library/jest-dom in README.md
#172
Conversation
Instead of `jest-dom` which is now deprecated
Codecov Report
Merging #172 (632546e) into master (8466f70) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #172 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 90 90 Branches 28 28 ========================================= Hits 90 90
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 8466f70...632546e. Read the comment docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks!
Hey folks! I'm just starting out with
@testing-library/vueand since the README saidYou may also be interested in installing jest-domI tried installing it, only to then find out it was moved to@testing-library/jest-dom, so I had to install the other one.Perhaps this little change could save other people some time - I'd be happy if you considered accepting it.
Thanks for reading 😊