Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

chore: switch to github actions #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickserv merged 2 commits into master from pr/use-actions-instead
Nov 14, 2020
Merged

chore: switch to github actions #171

nickserv merged 2 commits into master from pr/use-actions-instead
Nov 14, 2020

Conversation

@nickserv
Copy link
Member

@nickserv nickserv commented Nov 14, 2020 •
edited
Loading

Generated with yo kcd-oss

See testing-library/dom-testing-library#809 for rationale and history

Copy link

codecov bot commented Nov 14, 2020 •
edited
Loading

Codecov Report

Merging #171 (4aac75d) into master (920dff2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph 

@@ Coverage Diff @@
## master #171 +/- ##
=========================================
 Coverage 100.00% 100.00% 
=========================================
 Files 1 1 
 Lines 71 90 +19 
 Branches 13 28 +15 
=========================================
+ Hits 71 90 +19
Impacted Files Coverage Δ
src/vue-testing-library.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 920dff2...4aac75d. Read the comment docs.

Copy link
Member Author

I've also fixed the ESLint config. This is technically broken on master, but Travis succeeds anyway because it caches old dependencies, which Actions doesn't.

Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 😍 I guess there's no way to test the release job until there's, well, a release, right? 😂

Copy link
Member Author

A similar config has already been used with the other packages so I think it should be fine.
afontcu reacted with heart emoji

@nickserv nickserv merged commit 8466f70 into master Nov 14, 2020
@nickserv nickserv deleted the pr/use-actions-instead branch November 14, 2020 10:43
Copy link

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jun 8, 2022

🎉 This PR is included in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afontcu afontcu afontcu approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /