-
Notifications
You must be signed in to change notification settings - Fork 113
Move types from DefinitelyTyped to this repository #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line productes the following warning with latest config:
void is only valid as a return type or generic type variable
@typescript-eslint/no-invalid-void-type
not entirely sure I should be worried about this?
Codecov Report
Merging #165 (34594eb) into master (53ff893) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #165 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 90 90 Branches 28 28 ========================================= Hits 90 90
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 53ff893...34594eb. Read the comment docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support for this is now built-in to the latest version of kcd-scripts (actually, eslint-config-kentcdodds, but that's what kcd-scripts uses).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I assumed when I checked the changelogs, but sadly enough eslint-plugin-vue requires us to use parserOptions.parser option instead of parser, because the latest needs to be used internally to parse Vue files.
SFC are cool but come with their own headaches 😅
Following the steps of DTL, RTL, and CTL, this PR brings types home.
Any feedback by TS pro's is really appreciated 🙌 @testing-library/core-maintainers