Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add warning message to fireEvent input and change when called directly #83 #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jhack32 wants to merge 2 commits into testing-library:master from jhack32:master

Conversation

@jhack32
Copy link
Contributor

@jhack32 jhack32 commented Oct 27, 2020

I've made an assumption here that whenever we get a second arg, it's coming from a direct call but would be happy to change it if it's an incorrect assumption. Let me know what y'all think!

Copy link

codecov bot commented Oct 28, 2020
edited
Loading

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@
## master #160 +/- ##
=========================================
 Coverage 100.00% 100.00% 
=========================================
 Files 1 1 
 Lines 70 74 +4 
 Branches 13 15 +2 
=========================================
+ Hits 70 74 +4 
Impacted Files Coverage Δ
src/vue-testing-library.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 357bc84...93e1dc4. Read the comment docs.

Copy link
Member

afontcu commented Oct 31, 2020

Hi, thanks for this!

I gave this some more thought and now I wonder what would happen for people using Vue Testing Lib + user-event... 🤔

Copy link
Contributor Author

jhack32 commented Oct 31, 2020

@afontcu I could add some test cases for user-event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /