-
Notifications
You must be signed in to change notification settings - Fork 113
Alternative approach for integration with Vuetify #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I suggest an alternative approach to the problem to preserve things like `props, propsData, updateProps` that are applied to the root node only.
Codecov Report
Merging #123 into master will not change coverage by
%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #123 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 67 67 Branches 13 13 ========================================= Hits 67 67
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 850bd4c...d36ab03. Read the comment docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks way better, thank you! I've added a couple of suggestions, then we're ready to merge 😄
Thanks for this! :)
I suggest an alternative approach to the problem to preserve things like
props, propsData, updatePropsthat are applied to the root node only.