-
Notifications
You must be signed in to change notification settings - Fork 113
add simple directive and test #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel the example is a bit "wordy" (it says value a lot 😝).
I think it would be best if we used a simpler example with a clearer directive. Also I'd love to avoid using updateProps, as it has actually nothing to do with directives, and people may get the wrong impression.
What do you think about that?
this was closed because I referenced it in #111, I'll fix the issues and reopen
Hi @chiptus! Any chance you could take a look at this? 😄
have a happy new year!
Co-Authored-By: Adrià Fontcuberta <afontcu@gmail.com>
will do
Fixed in #120. Thanks for this, though! 😃
fixes #108