-
Notifications
You must be signed in to change notification settings - Fork 33
feat(vitest): add vitest cleanup export #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
mcous
commented
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed / moved this file to avoid confusion with the src/vitest.js entrypoint
@mcous
mcous
changed the title
(削除) feat(vitest): add vitest cleanup import (削除ここまで)
(追記) feat(vitest): add vitest cleanup export (追記ここまで)
Jan 26, 2024
This was referenced Jan 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Overview
This is the first PR in a series to add multiple Svelte versions and test runners to our CI test matrix.
Change log
This PR concentrates on getting Vitest fully working, since there are a few issues with the setup
@testing-library/svelte/vitestimport, inspired by@testing-library/jest-dom/vitestto run auto-cleanup when using Vitest in non-global modetesting-library/jest-domso we can use@testing-library/jest-dom/vitestjestargumentsReview requests
(削除) I'm keeping this PR in draft mode until I can verify that theVerified, works like a charm@testing-library/svelte/vitestimport works in a real project. Importingvitestin library code has given me issues before, so I want to verify before this is merged/released. It definitely works for our own test suite, though! (削除ここまで)