Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: Added the option to allow modification of sns access policy #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

@dchocoboo
Copy link

@dchocoboo dchocoboo commented Nov 6, 2024

Description

Modified the main.tf and variables.tf to add input sns_topic_access_policy

Motivation and Context

Reason being, some other services such as AWS backup need to be added to the access policy, so the service can trigger the SNS.
by default

Breaking Changes

no

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

kaykhan reacted with thumbs up emoji
david tjokroaminoto added 2 commits November 6, 2024 13:58
@dchocoboo dchocoboo changed the title (削除) chore: added the option to allow modification of sns access policy (削除ここまで) (追記) Chore: added the option to allow modification of sns access policy (追記ここまで) Nov 6, 2024
@dchocoboo dchocoboo changed the title (削除) Chore: added the option to allow modification of sns access policy (削除ここまで) (追記) chore : added the option to allow modification of sns access policy (追記ここまで) Nov 6, 2024
@dchocoboo dchocoboo changed the title (削除) chore : added the option to allow modification of sns access policy (削除ここまで) (追記) chore: Added the option to allow modification of sns access policy (追記ここまで) Nov 6, 2024
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

Copy link

github-actions bot commented Jan 3, 2025

This PR was automatically closed because of stale in 10 days

Copy link

github-actions bot commented Feb 2, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /