Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix: Make default tag terraform-aws-modules optional #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

@sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Jan 25, 2025 •
edited
Loading

Description

PR makes default tag terraform-aws-modules with value lambda optional.

Motivation and Context

Resolves #651

Breaking Changes

PR introduces new variable include_default_tag, but it's not breaking change as this variable has defined default value.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let's rename the variable.

sebastianczech reacted with thumbs up emoji
Copy link
Contributor Author

sebastianczech commented Jan 25, 2025 •
edited
Loading

thank you @antonbabenko for quick review and suggestion - I've updated the variable name.

@antonbabenko antonbabenko merged commit 685af53 into terraform-aws-modules:master Jan 26, 2025
30 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 26, 2025 
## [7.20.1](v7.20.0...v7.20.1) (2025年01月26日)
### Bug Fixes
* Make default tag `terraform-aws-modules` optional ([#657](#657)) ([685af53](685af53))
Copy link
Member

This PR is included in version 7.20.1 🎉
sebastianczech and hans-d reacted with thumbs up emoji

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No hardcoded tags like terraform-aws-modules = "lambda"

AltStyle によって変換されたページ (->オリジナル) /