Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Renamed python3.8-11 to python3.12 in examples, added tag to resources #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonbabenko merged 3 commits into master from feat-tam-tags
Jun 7, 2024

Conversation

@antonbabenko
Copy link
Member

@antonbabenko antonbabenko commented Jun 7, 2024

  • feat: Added terraform-aws-modules tag
  • feat: Renamed python3.[8-11] => python3.12 in examples

@antonbabenko antonbabenko changed the title (削除) feat tam tags (削除ここまで) (追記) feat: Renamed python3.[8-11] to python3.12 in examples, added tag to resources (追記ここまで) Jun 7, 2024
}

tags = merge(var.tags, var.function_tags)
tags = merge(
Copy link
Member Author

@antonbabenko antonbabenko Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryantbiggs WDYT about tags? (the rest of the renaming was automatic)

Copy link
Member

@bryantbiggs bryantbiggs Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function def, there won't be any insight into the s3 object, cloudwatch could technically be derived but ok either way. Typically, the fewer the better, and tag the main thing which other things can be derived off of that

antonbabenko reacted with thumbs up emoji
Copy link
Member Author

@antonbabenko antonbabenko Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 16b854a

@antonbabenko antonbabenko changed the title (削除) feat: Renamed python3.[8-11] to python3.12 in examples, added tag to resources (削除ここまで) (追記) feat: Renamed python3.8-11 to python3.12 in examples, added tag to resources (追記ここまで) Jun 7, 2024
@antonbabenko antonbabenko merged commit 02ab668 into master Jun 7, 2024
antonbabenko pushed a commit that referenced this pull request Jun 7, 2024
## [7.5.0](v7.4.0...v7.5.0) (2024年06月07日)
### Features
* Renamed python3.8-11 to python3.12 in examples, added tag to resources ([#583](#583)) ([02ab668](02ab668))
Copy link
Member Author

This PR is included in version 7.5.0 🎉

@antonbabenko antonbabenko deleted the feat-tam-tags branch June 7, 2024 21:22
Copy link

github-actions bot commented Jul 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /