-
-
Couldn't load subscription status.
- Fork 739
feat: Added control to create logs by Lambda@Edge in all regions #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added control to create logs by Lambda@Edge in all regions #462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of restricting logs by region, but I propose changing the name of the variable to something like lambda_at_edge_logs_all_regions.
Also, please remove the changes from examples/complete/main.tf as it is a very minor case.
variables.tf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
examples/complete/main.tf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6b66eb9 to
bcff87b
Compare
@antonbabenko changed according to your suggestions
## [4.18.0](v4.17.0...v4.18.0) (2023年05月17日) ### Features * Added control to create logs by Lambda@Edge in all regions ([#462](#462)) ([712d8ec](712d8ec))
This PR is included in version 4.18.0 🎉
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Description
Added simple flag, for not create IAM policy which allows to create logs by Lambda@Edge in regions other than N.Virginia.
Motivation and Context
In some cases that logs are not necessary, but storing it costs extra $.
Breaking Changes
NO
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request