-
-
Couldn't load subscription status.
- Fork 740
feat: Add support to build automatically npm dependencies #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...ort. Change default docker image from lambci to offical AWS SAM images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good! Just a small addition - please mention this new feature in README somewhere and update code in examples to use it for real (this is going to be a confirmation that this PR does what it supposes). Thank you!
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
I have finished it in #293 because I didn't have permission to push to your fork.
This issue has been resolved in version 2.36.0 🎉
Top! Thanks :)
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Description
As made for pip requirements, this PR adds support to build Nodejs dependencies automatically with or without docker.
Motivation and Context
This PR simplifies the process needed to build and deploy Nodejs functions and, thanks to docker, allows users to build functions without the need to have the interpreter installed locally
Breaking Changes
No breaking changes introduced
How Has This Been Tested?
examples/*projects