-
Notifications
You must be signed in to change notification settings - Fork 724
Finish deprecating enable_template_filesystem_access
#4222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated gateway.enable_template_filesystem_access configuration field and its associated migration logic, simplifying the gateway configuration handling.
Key changes:
- Removed the deprecated
enable_template_filesystem_accessfield fromUninitializedGatewayConfig - Simplified the
load()method by removing the migration logic that handled both old and new configuration formats - Updated inline documentation to use proper markdown formatting for code snippets
- Removed the test for deprecated field behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tensorzero-core/src/config/gateway.rs | Removed deprecated field, migration logic, and unused ErrorDetails import; simplified template_filesystem_access initialization |
| tensorzero-core/src/config/mod.rs | Fixed inline documentation formatting to use backticks instead of single quotes for code snippet |
| tensorzero-core/src/config/tests.rs | Removed test for deprecated configuration field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TensorZero CI Bot Automated Comment
The CI failure is coming from the check-node-bindings job. After building the Node bindings, the workflow detected an uncommitted change in internal/tensorzero-node/lib/bindings/TemplateFilesystemAccess.ts. This was triggered by the Rust doc comment change you made in tensorzero-core/src/config/mod.rs, where '{% include %}' was updated to `{% include %}`. The bindings are generated from those Rust types/docs, so the generated TS file also needs to be updated and committed.
I’ve included a patch that updates the generated TemplateFilesystemAccess.ts to match the new doc comment so that the "git diff --exit-code" check will pass. The subsequent "check-all-general-jobs-passed" failure is a cascade from this job and should be resolved once the bindings diff is committed.
Note: The "Upload bindings artifact on diff failure" step error about NSC_TOKEN_FILE is only executed on failure paths and does not indicate a separate issue with the codebase.
I've opened an automated follow-up PR #4224 with proposed fixes.
Co-authored-by: TensorZero-Experimental-CI-Bot[bot] <hello@tensorzero.com>
Uh oh!
There was an error while loading. Please reload this page.
Fix #2864
Important
Remove deprecated
enable_template_filesystem_accessfrom configuration and update related logic and tests.enable_template_filesystem_accessfromUninitializedGatewayConfigingateway.rs.load()inUninitializedGatewayConfigto usetemplate_filesystem_accessdirectly.test_deprecated_enable_template_filesystem_access()fromtests.rs.mod.rsforTemplateFilesystemAccess.This description was created by Ellipsis for 02327ae. You can customize this summary. It will automatically update as commits are pushed.