Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add sleep statements to dataset tests for clickhouse consistency #4017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shuyangli merged 1 commit into main from sl/add-sleeps-to-db-e2e-tests
Oct 17, 2025

Conversation

@shuyangli
Copy link
Contributor

@shuyangli shuyangli commented Oct 17, 2025
edited
Loading

In dataset_queries, every time we need to read an updated value after writing, we sleep for a second to allow ClickHouse to become consistent. ClickHouse doesn't give us read-after-write consistency guarantees in replicated settings with HTTP connections, so this is the best we can do in the short term for these tests where we're writing test data :(

Also deleted test_stale_datapoint tests because we have coverage in test_*_datapoint_lifecycle_insert_get_delete


Important

Add sleep statements in dataset_queries.rs tests for ClickHouse consistency and remove two stale datapoint tests.

  • Behavior:
    • Add tokio::time::sleep for 1 second after write operations in dataset_queries.rs to ensure ClickHouse consistency.
    • Affects tests like test_count_datasets, test_count_datapoints_for_dataset_function_chat, and test_insert_datapoint_chat.
  • Removals:
    • Remove test_stale_datapoint_chat and test_stale_datapoint_json functions from dataset_queries.rs.

This description was created by Ellipsis for f63150c. You can customize this summary. It will automatically update as commits are pushed.

ellipsis-dev[bot] reacted with rocket emoji
@shuyangli shuyangli added this pull request to the merge queue Oct 17, 2025
Merged via the queue into main with commit 7c7385c Oct 17, 2025
32 checks passed
@shuyangli shuyangli deleted the sl/add-sleeps-to-db-e2e-tests branch October 17, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aaron1011 Aaron1011 Aaron1011 approved these changes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /