-
Notifications
You must be signed in to change notification settings - Fork 723
Add sleep statements to dataset tests for clickhouse consistency #4017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaron1011
Aaron1011
approved these changes
Oct 17, 2025
GabrielBianconi
pushed a commit
that referenced
this pull request
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
In dataset_queries, every time we need to read an updated value after writing, we sleep for a second to allow ClickHouse to become consistent. ClickHouse doesn't give us read-after-write consistency guarantees in replicated settings with HTTP connections, so this is the best we can do in the short term for these tests where we're writing test data :(
Also deleted test_stale_datapoint tests because we have coverage in test_*_datapoint_lifecycle_insert_get_delete
Important
Add sleep statements in
dataset_queries.rstests for ClickHouse consistency and remove two stale datapoint tests.tokio::time::sleepfor 1 second after write operations indataset_queries.rsto ensure ClickHouse consistency.test_count_datasets,test_count_datapoints_for_dataset_function_chat, andtest_insert_datapoint_chat.test_stale_datapoint_chatandtest_stale_datapoint_jsonfunctions fromdataset_queries.rs.This description was created by Ellipsis for f63150c. You can customize this summary. It will automatically update as commits are pushed.