Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix #889: add missing repo info and fix wrong argument to gh #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhucka wants to merge 3 commits into tensorflow:master from mhucka:mh-fix-889

Conversation

@mhucka
Copy link
Member

@mhucka mhucka commented Aug 29, 2025
edited
Loading

gh pr view can take the PR info in a number of ways, but does not recognize the URLs produced by ${{github.event.pull_request.url}} as being a pull request URL. This reuslts in failures like the one in #889.

This workflow was working before. Something must have changed – perhaps a version update to gh changed the behavior. In any case, one straightforward way to resolve it is to give it a PR number instead of a URL.

If a PR number is given, though, then gh also needs to be told which repository the PR number refers to. gh would normally get this info from the current repo where it's executing, but since for efficiency we skip doing a git check-out for that step, it needs to be told explicitly. A simple solution is to set the $GH_TOKEN environment variable, which gh uses if it's defined.

mhucka added 2 commits August 29, 2025 20:48
Unless executed in a git repository, `gh` no longer seems to get
information about the current repo where it's executing, which leads to
failures like the one in tensorflow#889. A simple solution is to set the
`$GH_TOKEN` environment variable, which `gh` uses if it's defined.
@mhucka mhucka changed the title (削除) Set GH_REPO for the gh CLI tool (削除ここまで) (追記) Fix #889: add missing repo info and fix wrong argument to gh (追記ここまで) Aug 29, 2025
@mhucka mhucka marked this pull request as ready for review August 29, 2025 22:41
@mhucka mhucka added area/health Involves general matters of project configuration, health, maintenance, and similar concerns area/ci Involves continuous integration workflows and infrastructure labels Aug 30, 2025
Copy link
Member Author

mhucka commented Aug 30, 2025

Closing this, after off-line discussions led us to conclude that the whole workflow should be reverted back to a prior state. PR #892 will revert it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelBroughton MichaelBroughton Awaiting requested review from MichaelBroughton

Assignees

No one assigned

Labels

area/ci Involves continuous integration workflows and infrastructure area/health Involves general matters of project configuration, health, maintenance, and similar concerns

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /