Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Layers phase 1 #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JimClarke5 wants to merge 49 commits into tensorflow:master from JimClarke5:layers_phase_1
Closed

Conversation

@JimClarke5
Copy link
Contributor

@JimClarke5 JimClarke5 commented May 6, 2021

These are the first set of model layers, fairly simple ones without back propagation.

I have also revamped the TestSession, GraphTestSession and EagerTestSession to use lambdas for common operations between the Graph and Eager modes. This will need to be updated with #272, "Tensor.dataToString" when that is merged.

This PR supersedes #65, "Adding layers (based on keras) supporting multiple outputs"

This PR is dependent on PRs #255 "Framework Ops", and #191 "TensorFormat enum". I temporary created a copy of TensorFormat until #191 is merged.

The layers framework supports multiple inputs and outputs, but some layers are restricted to single input/output by design,
(e.g. Dense).

SequentialLayersTest tests chaining layers together like in the Sequential Model.

Sync with master tensorflow on upstream
Merge main branch to local branch
Moved tf.raw.nn Ops to tf.nn.
Changed generation to generate SoftmaxCrossEntropyWithLogits and SparseSoftmaxCrossEntropyWithLogits to core NNOps (tf.nn).
Added NnOps and SetOps as groups.
Fixed MetricsHelper and Losses to use the bew FrameworkOps.
Moved SetsOps to framework.op.
Added NnOps and SetOps as groups.
Fixed MetricsHelper and Losses to use the bew FrameworkOps.
Moved SetsOps to framework.op.
Moved tf.raw.nn Ops to tf.nn.
Changed generation to generate SoftmaxCrossEntropyWithLogits and SparseSoftmaxCrossEntropyWithLogits to core NNOps (tf.nn).
Added NnOps and SetOps as groups.
Fixed MetricsHelper and Losses to use the bew FrameworkOps.
Moved SetsOps to framework.op.
Added NnOps and SetOps as groups.
Fixed MetricsHelper and Losses to use the bew FrameworkOps.
Moved SetsOps to framework.op.
JimClarke5 added 15 commits May 2, 2021 18:51
...l on the AssertThats. This change is unrelated to this PR, but the bug showed up here.
Copy link
Contributor Author

@Craigacp FYI: I had to change tf.nn.raw.softmaxCrossEntropyWithLogits to tf.nn.softmaxCrossEntropyWithLogits in GradientDescentTest to match the new Framework Ops. tf only contains the raw ops, the higher level ops are in org.tendorflow.framework.op

Craigacp reacted with thumbs up emoji

JimClarke5 added 4 commits May 6, 2021 19:45
Add softmax test, fixed bugs in framework softmax
...dded NNhelper for the transpose code,
change softmax to use the transpose code and added logSoftmax to do the same thing. Added test cases for logSoftmax.
Copy link
Contributor Author

@karllessard I am replacing this branch with a new branch based on the latest version of Master. This branch is out of sync with master, an won't successfully rebase. Therefore, I am creating a new branch and will be replacing this PR with a new one.

karllessard reacted with thumbs up emoji

Copy link
Contributor Author

This PR is being closed because the code became too stable with respect to Master. A new PR is being created to replace this one.

@JimClarke5 JimClarke5 deleted the layers_phase_1 branch June 15, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /