-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Update google.py to remove the native word #2394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A lot of Gemini models are native image out or native audio, so this rule was raising too many false positives.
@lucianommartins
lucianommartins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this go in the Gemini cookbook styles? the change doesn't seem Google-wide.
Can this go in the Gemini cookbook styles? the change doesn't seem Google-wide.
It can't, they are not the same thing. We're applying both styles at the moment... I could merge both into one, but that's way more work and I thought that we were the only ones using this script anyway...
A lot of Gemini models are native image out or native audio, so this rule was raising too many false positives.