Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed typos in requirements.txt and upgraded vulnerable packages #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
audiovideoron wants to merge 1 commit into talkpython:main from audiovideoron:main
Closed

Conversation

@audiovideoron
Copy link

@audiovideoron audiovideoron commented Mar 2, 2024

Michael,

I'm a new programmer and am not sure if I'm doing the git/github pull request properly. Anyway, I found two typos in the requirements.txt that cause requirements to remain unfulfilled after 'pip install -r requirements.txt' and and I updated a couple versions for vulnerabilities. Let me know if you have questions or concerns.

Thank you,

Ron Parker

Copy link
Member

Hi @audiovideoron Thanks for sending this in. It looks like you're doing things right w.r.t. github. However, I'm not going to accept it since it makes changes that aren't meaningful for the project. The .idea files should probably just be excluded from the repo and more importantly:

pip install typing-extensions

is the same as

pip install typing_extensions

Just when using them in python you must use the _ over -. Thank you.

Copy link
Author

audiovideoron commented Mar 4, 2024 via email

The problem is Pycharm persists in warning that the requirements aren’t met. If you don’t understand that it can be ignored then it’s confusing. And then you spin your wheels trying to meet the requirements. Ron ***@***.*** Mar 3, 2024, at 4:13 PM, Michael Kennedy ***@***.***> wrote: Hi @audiovideoron Thanks for sending this in. It looks like you're doing things right w.r.t. github. However, I'm not going to accept it since it makes changes that aren't meaningful for the project. The .idea files should probably just be excluded from the repo and more importantly: pip install typing-extensions is the same as pip install typing_extensions Just when using them in python you must use the _ over -. Thank you. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

Copy link
Member

Ah I see @audiovideoron This turns out to be a bug in PyCharm. I just submitted it to them here:

https://youtrack.jetbrains.com/issue/PY-71235/package-with-dash-shows-as-requirements-not-met-when-they-are

They are usually pretty quick to jump on these. Fingers crossed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /