-
Couldn't load subscription status.
- Fork 393
Fix order of API view functions #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mikeckennedy
merged 1 commit into
talkpython:master
from
tbrlpld:fix-days-097-100-backend-routes
Jan 28, 2020
Merged
Fix order of API view functions #29
mikeckennedy
merged 1 commit into
talkpython:master
from
tbrlpld:fix-days-097-100-backend-routes
Jan 28, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the routes/views with parameters in the URL where defined first.
E.g. `@api.route("/api/movie/genre/{genre}")` was defined before
`@api.route("/api/movie/genre/all")`.
When trying to hit the URL for `/api/movie/genre/all` the response would
be empty. This is because the this would not trigger the desired view,
but the parameterized view would be passes `genre = all`. Since there
are no movies with the genre "all" the response would be empty.
To solve this issue, the ordering of the routes/views had to be
adjusted. Now the most specific views are defined first, and then the
more flexible views are defined.
Thanks. Something must have changed because this was OK when I recorded it AFAIK. Appreciate the update.
Yea, I assume there was a responder update that changed how the routes are looked up. I did not confirm this, but I saw it working in the videos too 😄
... On Jan 28, 2020, at 09:14, Michael Kennedy ***@***.***> wrote:
Thanks. Something must have changed because this was OK when I recorded it AFAIK. Appreciate the update.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the routes/views with parameters in the URL where defined first.
E.g.
@api.route("/api/movie/genre/{genre}")was defined before@api.route("/api/movie/genre/all").When trying to hit the URL for
/api/movie/genre/allthe response wouldbe empty. This is because the this would not trigger the desired view,
but the parameterized view would be passes
genre = all. Since thereare no movies with the genre "all" the response would be empty.
To solve this issue, the ordering of the routes/views had to be
adjusted. Now the most specific views are defined first, and then the
more flexible views are defined.