Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Hide user field in api front-end and set default #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbelderbos merged 3 commits into talkpython:master from tbrlpld:django-rest-user-field
Jan 4, 2020
Merged

Hide user field in api front-end and set default #25

bbelderbos merged 3 commits into talkpython:master from tbrlpld:django-rest-user-field
Jan 4, 2020

Conversation

@tbrlpld
Copy link
Contributor

@tbrlpld tbrlpld commented Dec 31, 2019
edited
Loading

Before, it was possible in the api font-end for a logged-in user to set the user value of a quote during create or update. This means, the user could set another user as the owner of the quote.

This behavior seems unintended.

To prevent this option, the user field is defined as a hidden field in the serializer. Hidden fields will not show up in the api frontend form.

A quote should have a user assigned to it (even if it is not required on the model level) to allow management (update/delete) of the quote. The quote can only be managed by it's owner. To prevent quotes without an owner, the hidden user field is assigned the default value of the currently logged-in user in the serializer.

This change was previously discussed with @bbelderbos via email.

Other commits mirror changes made before in the previous Quote app section (days/053-056).

This commit mirrors the commit a18b641
by @bbelderbos which fixes this issue in days/053-056.
This commit is mirroring ab86ca9 in
days/053-056.
Previously, the registration form would not show any field errors
that might occur during registration. This commit updates the
`registration_form.html` template in the demo as well as the starter
code to show occurring field errors.
Before, it was possible in the api font-end for a logged-in user to set
the user value of a quote during create or update. This means, the user
could set another user as the owner of the quote.
This behavior seems unintended.
To prevent this option, the user field is defined as a hidden field in
the serializer. Hidden fields will not show up in the api frontend form.
A quote should have a user assigned to it (even if it is not required on
the model level) to allow management (update/delete) of the quote. The
quote can only be managed by it's owner. To prevent quotes without an
owner, the hidden user field is assigned the default value of the
currently logged-in user in the serializer.
@bbelderbos bbelderbos self-assigned this Jan 1, 2020
Copy link
Member

Hi guys. Thank you @tbrlpld.

@bbelderbos this one looks good to me. You OK with me merging it?

Copy link
Collaborator

@mikeckennedy yep all good, forgot to merge it in. @tbrlpld great enhancement, I like your explanatory comment and also that you ported the template fix from the other PR into this project, thanks a lot!

@bbelderbos bbelderbos merged commit 85b09a1 into talkpython:master Jan 4, 2020
Copy link
Member

Thanks! :)

Copy link
Contributor Author

tbrlpld commented Jan 5, 2020 via email

Happy to help! 😊 Thank you guys for the course @mkennedy @bbelderbos
...
On Jan 4, 2020, at 13:04, Michael Kennedy ***@***.***> wrote:  Thanks! :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /