-
Notifications
You must be signed in to change notification settings - Fork 393
Add field errors to registration form template #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Before, it was possible to enter invalid data into the registration form, e.g. duplicate username, insecure password, etc., without being notified about the violation. The form would simply reload and no user is created and no email is sent. Without being notified about the registration form issue, one might assume that something in the setup is not correct and waste hours trying to debug something that is not broken. At least, that is what happened to me 😬 This commit adds the form field errors to the registration form template.
Thanks a lot @tbrlpld it's hard to see the diff here so I downloaded the new zip file and compared it with what I had. It seems you only updated django_registration/registration_form.html with the following changes, right?
@bbelderbos Yes, that was the only form where I was having the issue. Errors in the login form seem to be caught and displayed as above the form like other "non field errors" would. So no need to change that.
@tbrlpld great, I am seeing it locally now too so merging the fix. As discussed also pinning Django to 2.2 till django-registration becomes compatible with Django 3.x (issue ubernostrum/django-registration#191) - thanks
Thank you both for keeping this one fresh.
Before, it was possible to enter invalid data into the registration
form, e.g. duplicate username, insecure password, etc., without being
notified about the violation. The form would simply reload and no user
is created and no email is sent.
Without being notified about the registration form issue, one might
assume that something in the setup is not correct and waste hours
trying to debug something that is not broken. At least, that is what
happened to me 😬
This commit adds the form field errors to the registration form
template.
This change has been discussed with @bbelderbos view email.