Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Enhancements and Bug Fixes for Improved Compatibility and Functionality #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arsarsars1 wants to merge 4 commits into talkjs:main
base: main
Choose a base branch
Loading
from arsarsars1:main

Conversation

@arsarsars1
Copy link

@arsarsars1 arsarsars1 commented Jul 3, 2023

  • Added accessibility enhancements to ensure compatibility with the iOS platform.
  • Fixed Firebase authentication to work seamlessly on both iOS and Android platforms.
  • Removed flutter_apns dependency as it was causing disconnection issues.

arsarsars1 added 2 commits July 3, 2023 15:39
- fix the firebase auth to run on both platforms
- removed flutter_apns because it disconnected
Copy link
Collaborator

bugnano commented Jul 3, 2023

First of all thank you for your contribution.
Before being able to accept any PR, no matter how small, we require every contributor to sign either the Individual CLA or the corporate CLA that you find in this repo, and email it to legal@talkjs.com

Having said that, there are a couple of things that I don't like in this PR:

  1. Please don't reformat the sources, as it makes it nearly impossible to understand what are actual changes, and what are only automated formatting changes
  2. We don't use Firebase for push notifications on iOS, so removing the flutter_apns dependency results in breaking the push notifications on iOS

Copy link
Author

arsarsars1 commented Jul 3, 2023 via email

Hi, thank you for your response and for reviewing the PR. I noticed that the APNS (Apple Push Notification Service) was disconnected from the Flutter code, which caused issues with iOS crash analytics. To resolve this, I removed the APNS integration. Thank you. 
...
On 03-Jul-2023, at 4:54 PM, Franco Bugnano ***@***.***> wrote: First of all thank you for your contribution. Before being able to accept any PR, no matter how small, we require every contributor to sign either the Individual CLA or the corporate CLA that you find in this repo, and email it to ***@***.*** ***@***.***> Having said that, there are a couple of things that I don't like in this PR: Please don't reformat the sources, as it makes it nearly impossible to understand what are actual changes, and what are only automated formatting changes We don't use Firebase for push notifications on iOS, so removing the flutter_apns dependency results in breaking the push notifications on iOS — Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AICXBKJEYPMCTR3YHZYH5WDXOKXHBANCNFSM6AAAAAAZ4IU5AE>. You are receiving this because you authored the thread.

Copy link
Author

arsarsars1 commented Jul 3, 2023 via email

On 03-Jul-2023, at 4:59 PM, Abdul Rehman (A.R.S) ***@***.***> wrote: Hi, thank you for your response and for reviewing the PR. I noticed that the APNS (Apple Push Notification Service) was disconnected from the Flutter code, which caused issues with iOS crash analytics. To resolve this, I removed the APNS integration. Thank you.
...
> On 03-Jul-2023, at 4:54 PM, Franco Bugnano ***@***.***> wrote: > > > First of all thank you for your contribution. > Before being able to accept any PR, no matter how small, we require every contributor to sign either the Individual CLA or the corporate CLA that you find in this repo, and email it to ***@***.*** ***@***.***> > Having said that, there are a couple of things that I don't like in this PR: > > Please don't reformat the sources, as it makes it nearly impossible to understand what are actual changes, and what are only automated formatting changes > We don't use Firebase for push notifications on iOS, so removing the flutter_apns dependency results in breaking the push notifications on iOS > — > Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AICXBKJEYPMCTR3YHZYH5WDXOKXHBANCNFSM6AAAAAAZ4IU5AE>. > You are receiving this because you authored the thread. >

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /