-
Notifications
You must be signed in to change notification settings - Fork 23
Refine build system #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine build system #127
Conversation
- Remove duplicate git submodule initialization from Makefile header - Consolidate submodule init logic into $(KCONFIGLIB) target with proper error handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 3 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="mk/toolchain.mk">
<violation number="1" location="mk/toolchain.mk:28">
Substituting "clang" across the full CC path rewrites directory components (e.g. `/usr/local/clang+llvm/bin/clang` becomes `/usr/local/clang+++llvm/bin/clang++`), so clang++ cannot be located on such installations; please limit the substitution to the basename.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Substituting "clang" across the full CC path rewrites directory components (e.g. /usr/local/clang+llvm/bin/clang becomes /usr/local/clang+++llvm/bin/clang++), so clang++ cannot be located on such installations; please limit the substitution to the basename.
Prompt for AI agents
Address the following comment on mk/toolchain.mk at line 28:
<comment>Substituting "clang" across the full CC path rewrites directory components (e.g. `/usr/local/clang+llvm/bin/clang` becomes `/usr/local/clang+++llvm/bin/clang++`), so clang++ cannot be located on such installations; please limit the substitution to the basename.</comment>
<file context>
@@ -25,7 +25,7 @@ ifndef CXX
endif
ifeq ("$(CC_IS_CLANG)", "1")
-override CXX := $(dir $(CC))$(subst clang,clang++,$(notdir $(CC)))
+override CXX := $(subst clang,clang++,$(CC))
endif
</file context>
Uh oh!
There was an error while loading. Please reload this page.
Summary by cubic
Refined the build system by moving Kconfig submodule init into the KCONFIGLIB target with clear error handling, and fixed small toolchain/linker issues to prevent build failures.
Refactors
Bug Fixes