Fix interface of Raw nodes to make them extendable again #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

wooorm merged 3 commits into syntax-tree:main from Methuselah96:raw-type

Sep 13, 2022

Merged

Fix interface of Raw nodes to make them extendable again #66

wooorm merged 3 commits into syntax-tree:main from Methuselah96:raw-type

Sep 13, 2022

Conversation

@Methuselah96

Copy link

Contributor

@Methuselah96 Methuselah96 commented Sep 12, 2022 •

edited

Loading

Initial checklist

I read the support docs
I read the contributing guide
I agree to follow the code of conduct
I searched issues and couldn’t find anything (or linked relevant results below)
If applicable, I’ve added docs and tests

Description of changes

Resolves #65.

This PR expands the eslint-ignore block introduced in d97bcbd to include the Raw interface to make it compatible with other declarations of the Raw type in other packages.

@Methuselah96


 Make Raw type consistent with other packages

d7b1f03

@github-actions github-actions bot added 👋 phase/new 🤞 phase/open and removed 👋 phase/new labels

Sep 12, 2022

JounQin

JounQin approved these changes

Sep 12, 2022

View reviewed changes

wooorm

wooorm reviewed

Sep 12, 2022

View reviewed changes

complex-types.d.ts

import type {Literal} from 'hast'

export type Raw = {

export interface Raw extendsLiteral {

Copy link

Member

@wooorm wooorm Sep 12, 2022 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check your change locally, as I believe npm test will overwrite your changes. To keep them, include the needed xo ignore.

For why, see https://github.com/xojs/xo/releases/tag/v0.52.0.

Copy link

Contributor Author

@Methuselah96 Methuselah96 Sep 12, 2022 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now, thanks. I did run npm test, but expected it to cause the script to fail and didn't think to check to see if it overwrote the files. I've added back the eslint-diable/eslint-enable block.