Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix circular dependency #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wooorm merged 1 commit into syntax-tree:main from SQReder:fix-circular-deps
Jun 8, 2021
Merged

Fix circular dependency #56

wooorm merged 1 commit into syntax-tree:main from SQReder:fix-circular-deps
Jun 8, 2021

Conversation

@SQReder
Copy link
Contributor

@SQReder SQReder commented Jun 8, 2021

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Merged one.js and all.js into one file to avoid circular dependencies

fixes #55

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jun 8, 2021
@wooorm wooorm changed the title (削除) resolve circular dependencies - merge one.js and all.js (削除ここまで) (追記) Fix circular dependency (追記ここまで) Jun 8, 2021
@wooorm wooorm merged commit 58a75f4 into syntax-tree:main Jun 8, 2021

This comment has been minimized.

@wooorm wooorm added 💪 phase/solved Post is done and removed 🤞 phase/open Post is being triaged manually labels Jun 8, 2021
Copy link
Member

wooorm commented Jun 8, 2021

@SQReder SQReder deleted the fix-circular-deps branch June 8, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wooorm wooorm wooorm approved these changes

Assignees

No one assigned

Labels

💪 phase/solved Post is done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Circular dependencies break rollup build

2 participants

AltStyle によって変換されたページ (->オリジナル) /