-
-
Notifications
You must be signed in to change notification settings - Fork 14
Fix for email domains with no letters #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub does not link strings of the format mdast-util-gfm-autolink-literal@1.0.1 but will link if you add a letter to the label/domain. Emulate that behavior. Ref: remarkjs/remark#862
@github-actions
github-actions
bot
added
the
👋 phase/new
Post is being triaged automatically
label
Sep 24, 2021
This comment has been minimized.
This comment has been minimized.
@github-actions
github-actions
bot
added
🤞 phase/open
Post is being triaged manually
and removed
👋 phase/new
Post is being triaged automatically
labels
Sep 24, 2021
I can confirm that both algorithms employed by GH do not link them. I also tested some other semver versions:
react@0.11.1
react@0.12.0-rc1
react@0.14.0-alpha1
react@16.7.0-alpha.2
react@0.0.0-experimental-aae83a4b9
[ react@0.11.1
[ react@0.12.0-rc1
[ react@0.14.0-alpha1
[ react@16.7.0-alpha.2
[ react@0.0.0-experimental-aae83a4b9
react@0.11.1
react@0.12.0-rc1
react@0.14.0-alpha1
react@16.7.0-alpha.2
react@0.0.0-experimental-aae83a4b9
[ react@0.11.1
[ react@0.12.0-rc1
[ react@0.14.0-alpha1
[ react@16.7.0-alpha.2
[ react@0.0.0-experimental-aae83a4b9
wooorm
added a commit
to micromark/micromark-extension-gfm-autolink-literal
that referenced
this pull request
Sep 24, 2021
Related to d9eacf4. Related to remarkjs/remark#862. Related to syntax-tree/mdast-util-gfm-autolink-literal#5.
Investigating some more. I think the only rule between whether something links is whether the last character is a digit?
react@a
react@1
react@1.a
react@1.1
react@1.a-b
react@1.a1b
react@1.1-b
react@1.1-alpha
react@1.1-alpha1
react@1.1-a
react@1.a-1
This comment has been minimized.
This comment has been minimized.
@wooorm
wooorm
added
🐛 type/bug
This is a problem
👶 semver/patch
This is a backwards-compatible fix
💪 phase/solved
Post is done
🗄 area/interface
This affects the public interface
labels
Sep 24, 2021
@github-actions
github-actions
bot
removed
the
🤞 phase/open
Post is being triaged manually
label
Sep 24, 2021
LunanLore
added a commit
to LunanLore/Simple
that referenced
this pull request
Jul 31, 2025
Related to d9eacf49. Related to remarkjs/remark#862. Related to syntax-tree/mdast-util-gfm-autolink-literal#5.
SafariSanctay
added a commit
to SafariSanctay/bnintended
that referenced
this pull request
Aug 15, 2025
Related to d9eacf49. Related to remarkjs/remark#862. Related to syntax-tree/mdast-util-gfm-autolink-literal#5.
JohnisSmith
added a commit
to JohnisSmith/studioucs
that referenced
this pull request
Sep 12, 2025
Related to d9eacf49. Related to remarkjs/remark#862. Related to syntax-tree/mdast-util-gfm-autolink-literal#5.
dacutes
added a commit
to dacutes/1Pa
that referenced
this pull request
Sep 27, 2025
Related to d9eacf49. Related to remarkjs/remark#862. Related to syntax-tree/mdast-util-gfm-autolink-literal#5.
livemetaui
pushed a commit
to livemetaui/chainer
that referenced
this pull request
Oct 19, 2025
Related to d9eacf49. Related to remarkjs/remark#862. Related to syntax-tree/mdast-util-gfm-autolink-literal#5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Initial checklist
Description of changes
GitHub does not link strings of the format
mdast-util-gfm-autolink-literal@1.0.1 but will link if you add a letter
to the label/domain. Emulate that behavior.
Ref: remarkjs/remark#862