-
-
Notifications
You must be signed in to change notification settings - Fork 6
Update tsconfig.json
#7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ChristianMurphy
ChristianMurphy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jameshfisher!
node16 module resolution is something making its way through the ecosystem, but hasn't reached here yet.
Thanks for looking into it.
A couple items to get it across the finish line.
- Could you update the ts config of this project to use node16 resolution (using the same config options elsewhere https://github.com/syntax-tree/mdast-util-assert/blob/8958dff406cb658abc4189568ed7af2c56d9320c/tsconfig.json)
- Could you look into the type error currently breaking CI? (which may require going to some of this project's dependencies and updating them to support
node16mode as well)
wooorm
commented
Jan 27, 2023
Yup, you should be able to port this commit: syntax-tree/mdast-util-assert@8958dff. And things will work :)
jameshfisher
commented
Jan 28, 2023
@wooorm I've ported that commit, updated some dependencies, and tried to resolve some broken references in imports. It still has lots of type-checking errors though, and I don't know how to resolve them.
(It doesn't help that my laptop explodes and takes 15+ seconds for types to update when making any single-character changes in VS Code. This seems to be associated with instances of visit causing some perverse worst-case in type-checking. Any advice on this weird problem appreciated!)
@remcohaszing
remcohaszing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just 2 small suggestions
Co-authored-by: Remco Haszing <remcohaszing@gmail.com>
Co-authored-by: Remco Haszing <remcohaszing@gmail.com>
tsconfig.json (追記ここまで)
This comment has been minimized.
This comment has been minimized.
wooorm
commented
Jan 29, 2023
Thanks!
wooorm
commented
Jan 30, 2023
Released in 2.2.3!
Initial checklist
Description of changes
Fix issue described in #6