-
-
Couldn't load subscription status.
- Fork 4
Global JSX to local JSX w/ generics #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@github-actions
github-actions
bot
added
👋 phase/new
Post is being triaged automatically
🤞 phase/open
Post is being triaged manually
and removed
👋 phase/new
Post is being triaged automatically
labels
Apr 4, 2024
@wooorm
wooorm
changed the title
(削除) Update dev-dependencies (削除ここまで)
(追記) Global JSX to local JSX (追記ここまで)
Apr 4, 2024
@wooorm
wooorm
changed the title
(削除) Global JSX to local JSX (削除ここまで)
(追記) Global JSX to local JSX w/ generics (追記ここまで)
Apr 4, 2024
Closing this, I think it’s better for folks to define JSX: ae638ba. Similarly to how we expect a runtime to be passed in, it makes sentence that types are passed in too. And while TS doesn’t have a way to pass namespaces, a global seems good. Especially a global that is in use by millions of code examples out there.
This comment has been minimized.
This comment has been minimized.
@wooorm
wooorm
added
the
🙅 no/wontfix
This is not (enough of) an issue for this project
label
Oct 11, 2024
@github-actions
github-actions
bot
added
👎 phase/no
Post cannot or will not be acted on
and removed
🤞 phase/open
Post is being triaged manually
labels
Oct 11, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Cleaner but completely broken version of what GH-6 attempts.
This does not remove functionality (components).
But because TS limitations (and likely that
jsxtypes are not very good), we can’t infer someIntrinsicElementsregistry from ajsxfunction or anElementtype.