Check whether node.children is undefined #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

alexander-turner wants to merge 1 commit into syntax-tree:main from alexander-turner:patch-1

Closed

Check whether node.children is undefined #8

alexander-turner wants to merge 1 commit into syntax-tree:main from alexander-turner:patch-1

Conversation

@alexander-turner

Copy link

@alexander-turner alexander-turner commented Apr 1, 2024

Initial checklist

I read the support docs
I read the contributing guide
I agree to follow the code of conduct
I searched issues and couldn’t find anything (or linked relevant results below)
If applicable, I’ve added docs and tests (Note: I don't see where to add a test to make sure this gets caught)

Description of changes

A function wasn't checking that a property was defined before trying to access that property's length field. The function now returns the empty list if the property is undefined.

@alexander-turner


 Check whether node.children is undefined

a692b32

Signed-off-by: Alex Turner <alex@turntrout.com>

@github-actions github-actions bot added the 👋 phase/new label

Apr 1, 2024

@github-actions

This comment has been minimized.

@wooorm

Copy link

Member

wooorm commented Apr 1, 2024

Hey Alex! The function is only called on nodes with children. You are apparently seeing some issue. There is a root problem somewhere. You can try patching it here, but you’ll run into it everywhere. Better to figure out the root cause. Can you do some debugging and figure out why you have parent nodes without children?