-
-
Couldn't load subscription status.
- Fork 4
Refactor to use module augmentation instead of @ts-expect-error
#5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@remcohaszing
remcohaszing
added
🏡 area/internal
This affects the hidden internals
☂️ area/types
This affects typings
🤞 phase/open
Post is being triaged manually
labels
Feb 15, 2024
This removes the need for some `@ts-expect-error` comments.
@remcohaszing
remcohaszing
force-pushed
the
augment-untyped-modules
branch
from
February 15, 2024 13:22
af46ff0 to
56bf2f4
Compare
5 tasks
wooorm
wooorm
approved these changes
Feb 19, 2024
I don’t think that "mocking" the react types is better than a @ts-expect-error but fine if you want this
@wooorm
wooorm
changed the title
(削除) Use module augmentation to define missing types (削除ここまで)
(追記) Refactor to use module augmentation instead of Feb 19, 2024
@ts-expect-error (追記ここまで)
This comment has been minimized.
This comment has been minimized.
@github-actions
github-actions
bot
removed
the
🤞 phase/open
Post is being triaged manually
label
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
This removes the need for some
@ts-expect-errorcomments.