Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixes compatibility two polyfill functions with their behavior in mbsting extension in php 8.0 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
r00d1k wants to merge 1 commit into symfony:main from r00d1k:main

Conversation

@r00d1k
Copy link

@r00d1k r00d1k commented Jan 20, 2021

I tried to use symfony/console in my project. I use php 8.0 without mbstring ext. When console script runs without arguments I get this two fatals
PHP Fatal error: Uncaught TypeError: mb_detect_encoding(): Argument #1 ($string) must be of type string, null given
PHP Fatal error: Uncaught TypeError: mb_strwidth(): Argument #1 ($string) must be of type string, null given

In mbstring ext these functions returns string (5) 'ASCII' if null passed.

Copy link

symfony-bot bot commented Jan 20, 2021

Thanks for your pull request! We love contributions.

However, this repository is what we call a "subtree split": a read-only copy of one directory of the main Symfony polyfills repository. It is used by Composer to allow developers to depend on specific Symfony PHP polyfills.

If you want to contribute, you should instead open a pull request on the main repository:

https://github.com/symfony/polyfill

Thank you for your contribution!

PS: if you haven't already, please add tests, and beware that bug fixes should be submitted on the lowest maintained branch where they apply; only features should be submitted against the main branch.

Copy link
Member

Will be fixed by symfony/polyfill#330

r00d1k reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /