-
-
Notifications
You must be signed in to change notification settings - Fork 239
Removed legacy getter from LoggerChannelPass
#546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+13
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
GromNaN
reviewed
Oct 6, 2025
@HypeMC
HypeMC
force-pushed
the
remove-getter
branch
from
October 6, 2025 07:29
74f9453 to
833daad
Compare
GromNaN
GromNaN
approved these changes
Oct 6, 2025
Thank you @HypeMC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #545
The
LoggerChannelPass::getChannels()method was originally added in 4d5a969 for theDebugHandlerPassand was later used in theFixEmptyLoggerPass.Since both passes have been removed, this method is no longer needed.