Skip to content

Remove JavaScriptTypedArrayKind #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

kateinoigakukun merged 3 commits into master from typed-array-update

Sep 16, 2020

Merged

Remove JavaScriptTypedArrayKind #58

kateinoigakukun merged 3 commits into master from typed-array-update

Sep 16, 2020

Conversation

Copy link

Member

@j-f1 j-f1 commented Sep 16, 2020

Fixes #52.

j-f1 added 3 commits

September 16, 2020 10:42


 Remove JavaScriptTypedArrayKind

59a0a30


 Fix bugs

7b74f68


 Bump swjs_library_version

c0f9b56

Copy link

Member Author

j-f1 commented Sep 16, 2020

Reading through #57 reminded me that I did not bump the library version in #31. Is this an issue? Also, what’s the standard for how much to increment the version?

@kateinoigakukun

Copy link

Member

kateinoigakukun commented Sep 16, 2020

I did not bump the library version in #31. Is this an issue?

This is not a big issue because I bumped the version before releasing 0.6.0.

Also, what’s the standard for how much to increment the version?

At least it's ok if it's greater than the old value.

kateinoigakukun

kateinoigakukun approved these changes

View reviewed changes

@kateinoigakukun kateinoigakukun merged commit 6652885 into master

@kateinoigakukun kateinoigakukun deleted the typed-array-update branch

September 16, 2020 15:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@j-f1 @kateinoigakukun