-
-
Notifications
You must be signed in to change notification settings - Fork 57
RFC Implementation: Unify JSFunction and JSObject for consistent type system #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kateinoigakukun 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.
I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.
Co-authored-by: kateinoigakukun <11702759+kateinoigakukun@users.noreply.github.com>
Co-authored-by: kateinoigakukun <11702759+kateinoigakukun@users.noreply.github.com>
Co-authored-by: kateinoigakukun <11702759+kateinoigakukun@users.noreply.github.com>
Co-authored-by: kateinoigakukun <11702759+kateinoigakukun@users.noreply.github.com>
Copilot
AI
changed the title
(削除) [WIP] RFC: Unify JSFunction and JSObject (削除ここまで)
(追記) RFC Implementation: Unify JSFunction and JSObject for consistent type system (追記ここまで)
Aug 22, 2025
Copilot finished work on behalf of
kateinoigakukun
August 22, 2025 10:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR implements the RFC to unify JSFunction and JSObject, addressing fundamental design issues in the inheritance hierarchy and aligning the type system with JavaScript's dynamic callability semantics.
Problem
The existing architecture had several critical issues:
JSObject.global.Function.function!.newreturns a JSObject that should be callable but wasn't in our type systemSolution
This implementation unifies the architecture while maintaining complete backward compatibility:
1. Unified Callability
All JSObject instances now support function call operations:
2. Consistent Inheritance
Both closure types now consistently inherit from JSObject:
3. Unified JSValue Representation
Functions are now represented as objects internally:
Implementation Details
callAsFunction,new, and all argument overloads.functionproperty for backward compatibilityBackward Compatibility
All existing code continues to work unchanged:
.functionproperty now intelligently checks both.functionand.objectcasesJSFunctionclass remains available with full functionalityBenefits
Fixes #402.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.