Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Effectively revert the trait-based manifest change #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kateinoigakukun merged 2 commits into main from katei/revert-trait
Mar 28, 2025

Conversation

@kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Mar 28, 2025

Unfortunately, SwiftPM does not respect the enabled traits for validating the usage of unsafeFlags. After f9b3973, we are seeing the following validation error when a package depends on JavaScriptKit package with .package(url: "...", from:) form.

error: 'basic': the target 'JavaScriptKit' in product 'JavaScriptKit' contains unsafe build flags

We need to temporarily revert the trait change

Copy link

github-actions bot commented Mar 28, 2025 •
edited
Loading

Time Change: -99ms (1%)

Total Time: 9,599ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import with int 20ms -1ms (5%) ✅
View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import 22ms -0ms
Serialization/JavaScript function call from Swift 126ms -2ms (1%)
Serialization/Swift Int to JavaScript with assignment 324ms -1ms
Serialization/Swift Int to JavaScript with call 963ms -9ms (0%)
Serialization/JavaScript Number to Swift Int 260ms -5ms (1%)
Serialization/Swift String to JavaScript with assignment 405ms -0ms
Serialization/Swift String to JavaScript with call 1,055ms 0ms
Serialization/JavaScript String to Swift String 3,598ms -61ms (1%)
Object heap/Increment and decrement RC 2,793ms -18ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 8ms
Serialization/Assign JavaScript number directly 9ms
Serialization/Call with JavaScript number directly 5ms
Serialization/Write JavaScript string directly 7ms
Serialization/Call with JavaScript string directly 5ms

@kateinoigakukun kateinoigakukun marked this pull request as ready for review March 28, 2025 09:16
@kateinoigakukun kateinoigakukun merged commit c882581 into main Mar 28, 2025
6 checks passed
@kateinoigakukun kateinoigakukun deleted the katei/revert-trait branch March 28, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /