Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Make JSValue's subscript setter nonmutating #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kateinoigakukun merged 2 commits into main from katei/nonmutating-subscript-set
Mar 27, 2025

Conversation

@kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Mar 27, 2025 •
edited
Loading

Close #132 based on #270

Copy link

Time Change: +263ms (2%)

Total Time: 9,936ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import with int 22ms +4ms (18%) ⚠️
Serialization/Swift Int to JavaScript with assignment 332ms -22ms (6%) ✅
Serialization/JavaScript Number to Swift Int 263ms -13ms (5%) ✅
Serialization/Swift String to JavaScript with assignment 408ms -24ms (5%) ✅
Serialization/JavaScript String to Swift String 3,826ms +266ms (6%) 🔍
View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import 23ms -1ms
Serialization/JavaScript function call from Swift 129ms -5ms (4%)
Serialization/Swift Int to JavaScript with call 977ms -29ms (2%)
Serialization/Swift String to JavaScript with call 1,062ms -6ms (0%)
Object heap/Increment and decrement RC 2,863ms +97ms (3%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 8ms
Serialization/Assign JavaScript number directly 8ms
Serialization/Call with JavaScript number directly 5ms
Serialization/Write JavaScript string directly 6ms
Serialization/Call with JavaScript string directly 5ms

@kateinoigakukun kateinoigakukun marked this pull request as ready for review March 27, 2025 14:59
@kateinoigakukun kateinoigakukun merged commit 2989d8d into main Mar 27, 2025
6 checks passed
@kateinoigakukun kateinoigakukun deleted the katei/nonmutating-subscript-set branch March 27, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot set HTMLElement.style properties

2 participants

AltStyle によって変換されたページ (->オリジナル) /