-
-
Notifications
You must be signed in to change notification settings - Fork 57
Use JS's == operator for JSString equality comparison
#313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Time Change: +268ms (2%) Total Time: 9,730ms
View Unchanged
View Baselines
|
@kateinoigakukun
kateinoigakukun
force-pushed
the
maxd/jsstring-elementsequal
branch
from
March 25, 2025 15:41
6592626 to
90d7238
Compare
@kateinoigakukun
kateinoigakukun
changed the title
(削除) Use
(追記) Use JS's Mar 27, 2025
elementsEqual in JSString: Equatable conformance (削除ここまで)== operator for JSString equality comparison (追記ここまで)
kateinoigakukun
kateinoigakukun
approved these changes
Mar 27, 2025
@kateinoigakukun
kateinoigakukun
deleted the
maxd/jsstring-elementsequal
branch
March 27, 2025 04:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces binary size of products linked with JavaScriptKit when used with Embedded Swift. By relying on reference equality and otherwise on element-wise equality it avoids going through string normalization that would add a dependency on other portions of the Swift standard library.