-
-
Notifications
You must be signed in to change notification settings - Fork 57
Add --configuration option to swift package js command
#309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Time Change: +45ms (0%) Total Time: 9,557ms
View Unchanged
View Baselines
|
If we pass `-c release` as `swift package` option, command plugins will also be built in release configuration, which is not what we want.
@kateinoigakukun
kateinoigakukun
force-pushed
the
yt/configuration-option
branch
from
March 24, 2025 01:47
455b85e to
344c855
Compare
kateinoigakukun
added a commit
that referenced
this pull request
Mar 26, 2025
#309 introduced `-c` option to the plugin side in addition to the `swift package`'s one. However `swift package -c release js` was building with release config before 0.25.0 but it started to build with debug config as the default in 0.25.0. This change makes the plugin to respect the `swift package`'s one if `-c` is not specified after `js` plugin name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we pass
-c releaseasswift packageoption, command plugins will also be built in release configuration, which is not what we want.