Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Remove custom test framework #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kateinoigakukun merged 6 commits into main from yt/migrate-test-suite
Mar 14, 2025
Merged

Remove custom test framework #295

kateinoigakukun merged 6 commits into main from yt/migrate-test-suite
Mar 14, 2025

Conversation

@kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Mar 14, 2025 •
edited
Loading

We introduced a better test harness here #288, and there is no reason to use custom test framework. Let's migrate them to XCTest.

Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

Time Change: +241ms (2%)

Total Time: 9,874ms

Test name Duration Change
Serialization/Swift Int to JavaScript with assignment 359ms +19ms (5%) 🔍
Serialization/Swift Int to JavaScript with call 1,024ms +66ms (6%) 🔍
View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import 23ms -1ms
Serialization/JavaScript function call through Wasm import with int 23ms +0ms
Serialization/JavaScript function call from Swift 129ms +3ms (2%)
Serialization/JavaScript Number to Swift Int 285ms +10ms (3%)
Serialization/Swift String to JavaScript with assignment 433ms +14ms (3%)
Serialization/Swift String to JavaScript with call 1,084ms +44ms (4%)
Serialization/JavaScript String to Swift String 3,770ms +130ms (3%)
Object heap/Increment and decrement RC 2,730ms -43ms (1%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 3ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 3ms
Serialization/Call with JavaScript string directly 2ms

@kateinoigakukun kateinoigakukun marked this pull request as ready for review March 14, 2025 03:32
@kateinoigakukun kateinoigakukun merged commit e1dfcfe into main Mar 14, 2025
7 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/migrate-test-suite branch March 14, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /