-
-
Notifications
You must be signed in to change notification settings - Fork 57
Fix Optional implementation for ConstructibleFromJSValue #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
The current
Optional.constructreturnsnilwhen the given JS value isnullorundefined, butnilmeans a failure during decode here, so it's semantically wrong. Instead, it should return.some(nil)`.Also, when
Wrapped.constructreturnsnil, it means decode operation failed, soOptional.constructmethod should returnnil. But it might be unclear that the returnedOptional<Wrapped>value won't be implicitly casted to.some(nil), so I changed to returnnilbyguardstatement explicitly.Original description
現在の実装ではJSの値として
null,undefinedの場合に、Optional.constructがnilを返していますが、これはデコードの失敗を意味するため間違っています。
適切に
Optional.noneがデコードできた状況なので、.some(nil)を返す必要があります。また、
Wrapped.constructがnilを返した場合は、デコード失敗なので
nilを返すべきですが、ここで暗黙のキャストによって
.some(nil)が返ってしまうかどうか分かりづらいと思ったので、明示的に guard 文で分岐するように書き換えてみました。